Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Tests for /ipns paths and Cache-Control HTTP header #173

Merged
merged 5 commits into from
Oct 10, 2023
Merged

Conversation

hacdias
Copy link
Member

@hacdias hacdias commented Oct 2, 2023

This updates the conformance tests to bring them in line with the changes on the following PRs:

Currently, we are not allowing Cache-Control headers in /ipns paths, but that's about to change.

@hacdias hacdias self-assigned this Oct 2, 2023
@hacdias hacdias changed the title Ipns cache control Tests for /ipns paths and Cache-Control HTTP header Oct 2, 2023
@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Results against Kubo latest:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2045 0 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Results against Kubo master:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

@github-actions
Copy link
Contributor

github-actions bot commented Oct 2, 2023

Results against Kubo ns-cleanup:
(check the action's summary for the full results)

Summary

Tests Failures Errors Skipped
2046 0 0 0

@hacdias hacdias force-pushed the ipns-cache-control branch from e1ce435 to 1734a43 Compare October 2, 2023 13:00
@hacdias hacdias requested a review from lidel October 2, 2023 13:20
@hacdias
Copy link
Member Author

hacdias commented Oct 2, 2023

@lidel since the specifications say SHOULD all the time regarding Cache-Control and Last-Modified, I find it hard to write meaningful tests. For Cache-Control, I changed from "must not have" to "either is empty, or is public, max-age=*". Regarding Last-Modified, I simply did not add checks. The spec says it should be the resolution time. So that means it can either be set or not. The only thing I could do is checking if the date is valid if present, but that seems very meta into HTTP.

@hacdias hacdias marked this pull request as ready for review October 2, 2023 13:22
@hacdias hacdias force-pushed the ipns-cache-control branch from c026761 to f81afb8 Compare October 2, 2023 13:58
@lidel
Copy link
Member

lidel commented Oct 10, 2023

Ack, I think this is sensible for now. We will refine once DNSLink side of things is tackled in the future PRs.

@hacdias
Copy link
Member Author

hacdias commented Oct 10, 2023

As this needs to be merged, and published before merging the Boxo and Kubo PRs, I am going ahead and merge this once CI completes (just removed the Boxo branch).

@hacdias hacdias merged commit f158662 into main Oct 10, 2023
14 of 16 checks passed
@hacdias hacdias deleted the ipns-cache-control branch October 10, 2023 12:20
@github-actions github-actions bot mentioned this pull request Oct 11, 2023
@BigLep BigLep mentioned this pull request Nov 9, 2023
11 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
No open projects
Archived in project
Development

Successfully merging this pull request may close these issues.

2 participants